Fix HDR10 swapchain encoding by adding missing bt2020 color space conversion#3
Open
NotVoosh wants to merge 3 commits intosmolbbsoop:mainfrom
Open
Fix HDR10 swapchain encoding by adding missing bt2020 color space conversion#3NotVoosh wants to merge 3 commits intosmolbbsoop:mainfrom
NotVoosh wants to merge 3 commits intosmolbbsoop:mainfrom
Conversation
Author
|
Updated to fix compilation after some testing. Thanks @CreepySasquatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
HDR10 swapchain is not only encoded with PQ, but also in a different color space (Bt2020).
This PR adds proper conversion to Bt709 color space to match SDR and meet non-HDR-compatible shaders expectations.
Also: doing Tonemap and its Inverse in Bt2020 would be one way to partially preserve Wide Color Gamut colors through SDR effects.
I did not include it this PR as kind of a dirty simple trick, and I'm pretty sure there are better ways to achieve this, like Gamut Compression/Decompression.
Will look into adding this in a latter PR eventually.
Cheers